chore(protocols): specify raised exceptions (part 2) #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## raises-protocol-handler-no #1268 +/- ##
=============================================================
Coverage ? 84.55%
=============================================================
Files ? 93
Lines ? 16930
Branches ? 0
=============================================================
Hits ? 14315
Misses ? 2615
Partials ? 0
|
vladopajic
force-pushed
the
raises-protocol-2
branch
from
f71dd67 to
590e609
Compare
richard-ramos
approved these changes
Feb 27, 2025
| try: | ||
| await (await incomingConnection).connection.close() | ||
| except: | ||
| discard |
There was a problem hiding this comment.
Curious about the exception being generated here. Do you think it's worth it to add a trace log?
There was a problem hiding this comment.
i internationally didn't wanted to add log there, as compiler tells that AlreadyExpectingConnectionError can happen here, but, if this error happens it will happen only right after switch.connManager.expectConnection(pid, In) is called and that case is already handled. however i have added comment (to explain) and error log (it should never happen tho)
richard-ramos
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR specifies raised exceptions in
protocolsmodule. it is part 2, continuation to #1260.part of #962 effort.